New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos() returns incorrect units for dRHOdS #146

Open

sgyeager opened this issue Sep 9, 2022 · 1 comment

Contributor

sgyeager commented Sep 9, 2022

Calling eos() with return_coefs=True yields dRHOdS with units 'kg/m^3/degC'. I believe the correct units should be 'kg/m^3/g/kg'.

Collaborator

mnlevy1981 commented Sep 9, 2022

Thanks for opening an issue ticket about this! This was brought up under discussions (#143), but should have been converted to an issue.

From when I looked through the code, I saw a factor of 1000 that led me to believe the units are kg/m^3/kg/kg:

pop-tools/pop_tools/eos.py

Line 326 in f8dc20b

DRHODS = (WORK3 - WORK1 * DENOMK * WORK4) * DENOMK * 1000.0

we should definitely figure out if it is kg/m^3/g/kg or kg/m^3/kg/kg before addressing with a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment