Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the singular check for the Jacobian matrix #664

Closed
sjsprecious opened this issue Sep 19, 2024 · 0 comments · Fixed by #671
Closed

Remove the singular check for the Jacobian matrix #664

sjsprecious opened this issue Sep 19, 2024 · 0 comments · Fixed by #671
Assignees
Labels
bug Something isn't working

Comments

@sjsprecious
Copy link
Collaborator

Current in MICM, we will check whether the Jacobian matrix is singular or not after LuDecomposition (https://github.com/NCAR/micm/blob/main/include/micm/solver/rosenbrock.inl#L251-L252).

Based on my experience, CAM-Chem never did this in practical runs and this check can be costly for GPU runs because a synchronization is needed in order to return the correct value on the GPU (which is not done correctly right now).

Thus it may be easier to remove all the singular check in the MICM CPU & GPU code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant