Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use opendap #7

Merged
merged 12 commits into from
Dec 8, 2020
Merged

use opendap #7

merged 12 commits into from
Dec 8, 2020

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Dec 5, 2020

closes #6

either merge this PR or #8

todo:

  • check whether netcdf somehow works
  • check whether chunks good to provide
  • check whether source can/should be explicitly given somehow

@aaronspring
Copy link
Collaborator Author

aaronspring commented Dec 5, 2020

seems like it works, but takes ages
image

@aaronspring
Copy link
Collaborator Author

only upstream fails:

self = name: eMAST TERN
container: catalog
plugin: ['thredds_cat']
driver: ['thredds_cat']
description: THREDDS cat
direct_access: True
user_parameters: []
metadata: 
args: 
  url: http://dapds00.nci.org.au/thredds/catalogs/rr9/catalog.xml
user_parameters = {'name': 'eMAST TERN'}
plugin = <class 'intake_thredds.cat.ThreddsCatalog'>
open_args = {'metadata': {'catalog_dir': None}, 'name': 'eMAST TERN', 'url': 'http://dapds00.nci.org.au/thredds/catalogs/rr9/catalog.xml'}

    def get(self, **user_parameters):
        """Instantiate the DataSource for the given parameters"""
        if not user_parameters and self._default_source is not None:
            return self._default_source
    
        plugin, open_args = self._create_open_args(user_parameters)
>       data_source = plugin(**open_args)
E       TypeError: __init__() got an unexpected keyword argument 'name'

/opt/conda/lib/python3.7/site-packages/intake/catalog/local.py:285: TypeError

@aaronspring aaronspring marked this pull request as ready for review December 8, 2020 16:31
@aaronspring
Copy link
Collaborator Author

aaronspring commented Dec 8, 2020

upstream fails #9 as before

@aaronspring
Copy link
Collaborator Author

dont understand the linting error. there's no newline at the end of file

@martindurant martindurant merged commit 292a75f into intake:master Dec 8, 2020
@aaronspring aaronspring deleted the AS_use_opendap branch December 8, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circle CI fail before and after #3
2 participants