Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow xr_kwargs #32

Merged
merged 13 commits into from
May 6, 2021
Merged

Allow xr_kwargs #32

merged 13 commits into from
May 6, 2021

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented May 5, 2021 •
edited
Loading

Closes #30

  • allows: xarray_kwargs for THREDDSMergedSource
  • for ThreddsCatalog supply manually xarray_kwargs to entry
cat = intake.open_thredds_cat(f'https://psl.noaa.gov/thredds/catalog/Datasets/ncep.reanalysis/surface_gauss/catalog.xml', driver='netcdf')
cat['air.2m.gauss.1959.nc'](xarray_kwargs={'decode_times':False}).to_dask()

aaronspring
aaronspring commented May 5, 2021
View reviewed changes
intake_thredds/cat.py Outdated Show resolved Hide resolved
andersy005
andersy005 reviewed May 6, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together, @aaronspring! I left a few inline comments...

intake_thredds/cat.py Outdated Show resolved Hide resolved
intake_thredds/source.py Outdated Show resolved Hide resolved
@andersy005
Copy link
Member

Regarding the linting errors, you may want to install the pre-commit hooks: pre-commit install and run pre-commit run --all-files to fix the problematic files.

@aaronspring aaronspring marked this pull request as ready for review May 6, 2021 16:41
andersy005
andersy005 approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition, @aaronspring

@andersy005 andersy005 merged commit 399d0e5 into main May 6, 2021
@andersy005 andersy005 deleted the AS_xr_kwargs branch May 6, 2021 18:46
@andersy005 andersy005 added the enhancement New feature or request label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable xarray_kwargs
2 participants
@aaronspring @andersy005