-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation #19
Conversation
@martindurant, @aaronspring this is ready for review when you get a moment. Let me know if the tutorial notebook is missing anything or contains unclear explanations :). You can view the rendered version from https://intake-thredds--19.org.readthedocs.build/en/19/ |
I would also add section in the tutorial about the different drivers and simplecache. Should I add this? I am thinking of: Under the hood intake-thredds opens the import os
import fsspec
fsspec.config.conf['simplecache'] = {'cache_storage': 'my_caching_folder', 'same_names': True}
cat_url = 'https://psl.noaa.gov/thredds/catalog.xml'
source = intake.open_thredds_merged(
f'simplecache::{cat_url}',
path=['Datasets', 'ncep.reanalysis.dailyavgs', 'surface', 'air.sig995.194*.nc'],
driver='netcdf'
)
print(source)
ds = source.to_dask()
assert os.path.exists('my_caching_folder/air.sig995.1949.nc') see #20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really nice this new documentation, see #20 for additional section
Great improvements throughout. |
I thought I could just do catalog = intake.open_thredds_cat(cat_url, name='noaa-ersst-catalog') and intake would take care of the rest in https://github.com/NCAR/intake-thredds/blob/3d5e08c3d784f235f8139b8b1228629138da0eea/intake_thredds/cat.py#L8-L11 For some reason, the name argument doesn't get propagated to the base class and |
Yes, you can pass |
👍🏽 Good catch. Thanks! Should be fixed now |
Co-authored-by: Aaron Spring <[email protected]>
Not sure what's causing the Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/sphinx/config.py", line 327, in eval_config_file
execfile_(filename, namespace)
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/sphinx/util/pycompat.py", line 88, in execfile_
exec(code, _globals)
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/checkouts/19/docs/source/conf.py", line 17, in <module>
import intake_thredds
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/intake_thredds-0.0.post56-py3.7.egg/intake_thredds/__init__.py", line 8, in <module>
from .source import THREDDSMergedSource # noqa: F401
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/intake_thredds-0.0.post56-py3.7.egg/intake_thredds/source.py", line 3, in <module>
from intake_xarray.base import DataSourceMixin
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/intake_xarray/__init__.py", line 6, in <module>
from intake.container import register_container
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/intake/container/__init__.py", line 8, in <module>
from .dataframe import RemoteDataFrame
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/intake/container/dataframe.py", line 11, in <module>
from .base import RemoteSource, get_partition
File "/home/docs/checkouts/readthedocs.org/user_builds/intake-thredds/envs/19/lib/python3.7/site-packages/intake/container/base.py", line 8, in <module>
import msgpack
ModuleNotFoundError: No module named 'msgpack' |
This is still work in progress ...