Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: geocat.comp.ndpolyfit() moved upstream to Xarray. Should ndpolyfit be removed from geocat.comp? #63

Open
pilotchute opened this issue Apr 8, 2020 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@pilotchute
Copy link
Contributor

Xarray implemented polyfit and polyval on: pydata/xarray#3733
Should the duplicate functionality in geocat.comp.ndpolyfit be preserved?

To start the discussions:
Pros: maintains backward compatibility for all projects.

Cons: functionally with current polyfit in pydata.xarray is duplicated, and pydata.polyfit should become the reference implementation now that it has been moved upstream.

Potential resolution: refactor geocat.comp.ndpolyfit as an alias to pydata.xarrray.polyfit. this preserves compatibility with code that calls comp.ndpolyfit, while allowing xarray.polyfit to be the implementation.

@pilotchute pilotchute added the question Further information is requested label Apr 8, 2020
@erogluorhan erogluorhan self-assigned this Aug 21, 2020
@pilotchute
Copy link
Contributor Author

  • Resolution: refactor geocat.comp.ndpolyfit as an alias to pydata.xarrray.polyfit. this preserves compatibility with code that calls comp.ndpolyfit, while allowing xarray.polyfit to be the implementation.
  • tag with branch once this imporovement is started.

@anissa111
Copy link
Member

@pilotchute any updated thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants