Extract frequency from file #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersy005
reviewed
May 28, 2021
| @@ -103,6 +107,7 @@ def parse_cesm_history(file): | |||
| for v, da in ds.variables.items() | |||
| if time in da.dims and v not in {time, time_bounds} | |||
| ] | |||
| info['frequency'] = ds.attrs['time_period_freq'] | |||
There was a problem hiding this comment.
Thank you, @mgrover1! Can we confirm whether this time_period_freq attribute is only available in CESM2+? As far as I can remember from my conversation with @sherimickelson, older versions of CESM didn't output this attribute across all components.
|
Merging this shortly... @sherimickelson, your feedback/comment on #27 (comment) is still relevant, and appreciated :) |
andersy005
approved these changes
Jun 1, 2021
|
@andersy005 Taking a look at the CESM1-LE vs CESM2-LE datasets, it looks like CESM1 does not include the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the requirement that we get the frequency information from the stream name