Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carbonate chemistry should use in situ temperature, not potential temperature #217

Closed
klindsay28 opened this issue Jan 10, 2018 · 1 comment
Closed

carbonate chemistry should use in situ temperature, not potential temperature #217

klindsay28 opened this issue Jan 10, 2018 · 1 comment
Assignees
@klindsay28
Labels
bug
Milestone
MARBL1.0.0

Comments

@klindsay28
Copy link
Collaborator

According to Orr and Epitalon, GMD, 2015 (https://doi.org/10.5194/gmd-8-485-2015), the carbonate chemistry formulations that we use depend on in situ temperature, not potential temperature.

The fix will be to compute in situ temp in MARBL from potential temp and pass that to carbonate chemistry subroutines.

It also make sense to use in situ temp for biological processes as well.

AOU however, should continue to use potential temp.
@klindsay28 klindsay28 added the bug label Jan 10, 2018
@klindsay28 klindsay28 self-assigned this Jan 10, 2018
@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Jan 16, 2018
@mnlevy1981
Copy link
Collaborator

Fixed in marbl0.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klindsay28 klindsay28

Labels
bug
Projects
None yet
Milestone
MARBL1.0.0
Development

No branches or pull requests
2 participants
@mnlevy1981 @klindsay28