Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some log messages may exceed max length for character variables #167

Open
mnlevy1981 opened this issue May 31, 2017 · 1 comment
Open

Some log messages may exceed max length for character variables #167

mnlevy1981 opened this issue May 31, 2017 · 1 comment
Assignees
Labels

Comments

@mnlevy1981
Copy link
Collaborator

There are several places in the code where we write something to the variable log_message prior to updating the MARBL log with a call like

write(log_message, "(2A)") trim(str1), trim(str2)

we should really ensure that len_trim(str1) + len_trim(str2) <= len(log_message) before making those calls. (We are currently getting bitten by this in one section of marbl_config_mod due to a PGI compiler bug that seems to be populating str2 with garbage instead of setting it to what we want; there are other places where this sort of check could also come in handy, though.)

@mnlevy1981 mnlevy1981 added the bug label May 31, 2017
@mnlevy1981 mnlevy1981 added this to the Post-MARBL1.0.0 milestone May 31, 2017
@mnlevy1981 mnlevy1981 self-assigned this May 31, 2017
@mnlevy1981
Copy link
Collaborator Author

#168 addressed the specific instance in marbl_config_mod that was causing issues with PGI 17.4, but the issue as a whole has not yet been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant