Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule from Schema needs work #41

Open
sgoodlett opened this issue Jan 10, 2025 · 0 comments
Open

Molecule from Schema needs work #41

sgoodlett opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@sgoodlett
Copy link
Collaborator

There are a few issues I've noticed with how we use QCSchema to read xyz files.

  1. In the current workflow, QCSchema will always attempt to apply an Angstrom to Bohr unit conversion. We have circumvented this by telling QCSchema that the units are always in Bohr. This feels kind of hacky and I think needs looking into for a more stable solution.
  2. The way we process xyz files actually doesn't allow for properly formatted xyz file reading as we cannot handle when there is an atom number line and a comment line. This needs to be fixed.
@sgoodlett sgoodlett added the bug Something isn't working label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant