Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update software to handle catalog files the same fashion when specified via command-line versus config file #150

Open
salvioli opened this issue Oct 24, 2019 · 1 comment

Comments

@salvioli
Copy link

Describe the bug
It seems that the configuration file attribute validate.catalog and the command line parameter -C are not equivalent.

To Reproduce
Steps to reproduce the behavior:

  1. unzip dph_example_archive.zip
  2. run validate -c validate.conf -C catalog.xml
  3. run validate -c validate.conf
  4. The two results are different, hinting that the second run does not pick up the catalog file correctly. Indeed, in the second case, the list of parameters printed at the top of the validation report do not include the User Specified Catalogs item.

Expected behavior
Output passing the catalog file via -C option or via validate.catalog should be the same.

Version of Software Used

gov.nasa.pds:validate
Version 1.17.4
Release Date: 2019-10-22 13:54:19
Core Schema: PDS4_PDS_1D00.xsd
Core Schematron: PDS4_PDS_1D00.sch

Copyright 2019, by the California Institute of Technology ("Caltech").
All rights reserved.

Desktop (please complete the following information):

  • OS: Microsoft Windows 7 Professional 6.1.7601 Service Pack 1 Build 760
@salvioli salvioli added bug Something isn't working triage-needed labels Oct 24, 2019
@jordanpadams jordanpadams changed the title -C and validate.catalog do not generate the same output Update software to handle catalog files the same fashion when specified via command-line versus config file Dec 12, 2019
@jordanpadams jordanpadams added enhancement New feature or request p.could-have and removed bug Something isn't working s.low labels May 17, 2022
@github-project-automation github-project-automation bot moved this to Release Backlog in EN Portfolio Backlog Nov 20, 2023
@jstone-psi
Copy link

I just ran into this issue, as well.

It looks like the configuration handler never checks for ConfigKey.CATALOG, so the config file entry is being ignored:

public void query(File configuration) throws ConfigurationException {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

3 participants