1085: move from internal error to made up error #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
commented
Dec 18, 2024
| @@ -44,6 +44,8 @@ public enum ProblemType { | |||
|
|
|||
| CONTEXT_REFERENCE_NOT_FOUND("error.label.context_ref_not_found"), | |||
|
|
|||
| CONNECTION_ERROR("error.connection.registry"), | |||
There was a problem hiding this comment.
Make the characters inside quotes anything you want.
nutjob4life
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
✅ Visual inspection looks good
✅ Testing looks good
WARNING] Tests run: 252, Failures: 0, Errors: 0, Skipped: 23
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:37 min
Approved!
Unnecessary import
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Added new ProblemType.CONNECTION_ERROR and changed internal error to this.
⚙️ Test Data and/or Report
All unit tests below pass and visual inspection of code changes.
♻️ Related Issues
Closes #1085