Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want the total number of products returned to match both the total number of products expected to be loaded and the total number of products that were loaded #358

Open
jordanpadams opened this issue Jan 14, 2025 · 3 comments
Assignees
Labels

Comments

@jordanpadams
Copy link
Member

Checked for duplicates

No - I haven't checked

πŸ§‘β€πŸ”¬ User Persona(s)

Data User

πŸ’ͺ Motivation

...so that I know the data being loaded by harvest is accurate and the data returned by the API is accurate

πŸ“– Additional Details

Follow-on to NASA-PDS/harvest#147, it appears we may not have a test case that actually tests the number of hits expected to be returned by the API. This is a critical test we need implemented ASAP.

Acceptance Criteria

Given a test data set with X number of products
When I perform a harvest of the data set with --archive-status archived
Then I expect /products to return X number of hits

βš™οΈ Engineering Details

No response

πŸŽ‰ I&T

No response

@jordanpadams
Copy link
Member Author

@tloubrieu-jpl @alexdunnjpl to doublecheck, do we have any tests to check number of hits like this is asking?

@alexdunnjpl
Copy link
Contributor

@jordanpadams we have tests which (iirc) test that hits return GTE the expected value, but

  • it's GTE, because the assumption was that the minimal-representative test dataset would be expanded over time, and you wouldn't want to break all the tests looking at expected hits when that happens
  • the expected values were derived from whatever the value was at the time the test was created (the primary use-case, iirc, was to detect harvest breaking fatally and not ingesting what was expected, rather than validating harvest)

This should probably be moved to the registry repo, since it's an integration test and not a test of the API.

@jordanpadams
Copy link
Member Author

@alexdunnjpl πŸ‘

@jordanpadams jordanpadams transferred this issue from NASA-PDS/registry-api Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Status: ToDo
Development

No branches or pull requests

3 participants