You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a user, I want the total number of products returned to match both the total number of products expected to be loaded and the total number of products that were loaded
#358
Open
jordanpadams opened this issue
Jan 14, 2025
· 3 comments
...so that I know the data being loaded by harvest is accurate and the data returned by the API is accurate
π Additional Details
Follow-on to NASA-PDS/harvest#147, it appears we may not have a test case that actually tests the number of hits expected to be returned by the API. This is a critical test we need implemented ASAP.
Acceptance Criteria
Given a test data set with X number of products When I perform a harvest of the data set with --archive-status archived Then I expect/products to return X number of hits
βοΈ Engineering Details
No response
π I&T
No response
The text was updated successfully, but these errors were encountered:
@jordanpadams we have tests which (iirc) test that hits return GTE the expected value, but
it's GTE, because the assumption was that the minimal-representative test dataset would be expanded over time, and you wouldn't want to break all the tests looking at expected hits when that happens
the expected values were derived from whatever the value was at the time the test was created (the primary use-case, iirc, was to detect harvest breaking fatally and not ingesting what was expected, rather than validating harvest)
This should probably be moved to the registry repo, since it's an integration test and not a test of the API.
Checked for duplicates
No - I haven't checked
π§βπ¬ User Persona(s)
Data User
πͺ Motivation
...so that I know the data being loaded by harvest is accurate and the data returned by the API is accurate
π Additional Details
Follow-on to NASA-PDS/harvest#147, it appears we may not have a test case that actually tests the number of hits expected to be returned by the API. This is a critical test we need implemented ASAP.
Acceptance Criteria
Given a test data set with X number of products
When I perform a harvest of the data set with
--archive-status archived
Then I expect
/products
to return X number of hitsβοΈ Engineering Details
No response
π I&T
No response
The text was updated successfully, but these errors were encountered: