Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The members of a bundle can not be requested #261

Closed
tloubrieu-jpl opened this issue Feb 24, 2023 · 1 comment · Fixed by #263
Closed

The members of a bundle can not be requested #261

tloubrieu-jpl opened this issue Feb 24, 2023 · 1 comment · Fixed by #263
Assignees
Labels
B13.1 bug Something isn't working s.high High severity

Comments

@tloubrieu-jpl
Copy link
Member

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When I want to see the members of a bundle:

curl --request GET 'http://localhost:8081//products/urn:nasa:pds:insight_rad::2.1/members' \

--header 'Accept: application/json'

or

    curl --request GET 'http://localhost:8081//products/urn:nasa:pds:insight_rad::2.1/members/members' \

--header 'Accept: application/json'

I get an error:

{
"request": "//products/urn:nasa:pds:insight_rad::2.1/members",
"message": "The lidvid 'urn:nasa:pds:insight_rad::2.1' of type product does not support members membership"
}

🕵️ Expected behavior

I expected to get the collections (/members) or the observational products/documents (/memebers/members) of the bundle

📜 To Reproduce

See integration test cases in repository registry

🖥 Environment Info

No response

📚 Version of Software Used

1.2.0-SNAPSHOT on main branch

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 ##223

⚙️ Engineering Details

No response

@alexdunnjpl
Copy link
Contributor

alexdunnjpl commented Mar 7, 2023

@tloubrieu-jpl @jordanpadams Related discussion

Unless something has changed, it seems like the answer here is

  • if the error also exists for /classes/products/{identifier}/members, then (modify tests to) use /classes/bundles/{identifier}/members instead (which I personally think is a confusing requirement, but them's the breaks currently)
  • for deprecated endpoints (like /products/...), members/memberof subroutes are not and will not be implemented, and their equivalents aren't/won't be implemented for /products for the same reason as the previous bullet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B13.1 bug Something isn't working s.high High severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants