Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaggger ui error in production #211

Closed
tloubrieu-jpl opened this issue Dec 14, 2022 · 4 comments Β· Fixed by #254
Closed

swaggger ui error in production #211

tloubrieu-jpl opened this issue Dec 14, 2022 · 4 comments Β· Fixed by #254
Assignees
Labels
B13.1 bug Something isn't working i&t.done s.high High severity

Comments

@tloubrieu-jpl
Copy link
Member

πŸ› Describe the bug

See URL https://pds.nasa.gov/api/search/1/swagger-ui/index.html

πŸ•΅οΈ Expected behavior

The description of the API end-point should be visible when one arrives on the page.

πŸ“š Version of Software Used

registry-api 1.1.11 in the production environment

🩺 Test Data / Additional context

The behavior is different in production since the base URL of the API service is not a host name (as for http://pds.nasa.gov or http://localhost:8080) but there is a piece of URL path (/api/search/1) before the API sub-path. The swagger ui works if you replace /apidocs by https://pds.nasa.gov/api/search/1/api-docs in the input text on the top.

We need that to work by default

🏞Screenshots

image

πŸ–₯ System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

πŸ¦„ Related requirements

βš™οΈ Engineering Details

@tloubrieu-jpl tloubrieu-jpl added bug Something isn't working s.high High severity sprint-backlog labels Dec 14, 2022
@tloubrieu-jpl tloubrieu-jpl self-assigned this Dec 14, 2022
@tloubrieu-jpl
Copy link
Member Author

Some updates have been done in branch springdoc since the solution to have a working swagger-ui behing a reverse proxy was not possible with current library (springfox).

To make that fully work, I am also starting to upgrade the openapi generator maven plugin to the community version which will make us consistent with the python api client and apparently the project is the most dynamic to have the latest features and bug fixes.

@gxtchen
Copy link

gxtchen commented Apr 24, 2023

@tloubrieu-jpl production server is still showing the same error.

@tloubrieu-jpl
Copy link
Member Author

@gxtchen the version 1.2.0 tested by I&T is not deployed in production yet. I will deploy on gamma today where you should be able to test, as if in production.

@tloubrieu-jpl
Copy link
Member Author

tloubrieu-jpl commented Apr 24, 2023

Hi @gxtchen ,

I deployed on gamma https://pds.nasa.gov/api/search-en-gamma/1/swagger-ui/index.html
And I tested at the same time, it still fails, so I created this ticket NASA-PDS/registry#191

You can add it to the test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B13.1 bug Something isn't working i&t.done s.high High severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants