Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to be able to paginate over any number of results returned from a query. #176

Closed
jordanpadams opened this issue Aug 25, 2022 · 3 comments
Assignees
Labels
p.must-have requirement the current issue is a requirement sprint-backlog

Comments

@jordanpadams
Copy link
Member

💪 Motivation

...so that I can paginate through any number of results returned from the registry, with no performance lag, or restrictions due to tech stack

📖 Additional Details

Follow on to NASA-PDS/registry-mgr#53, we need to investigate a better solution for handling pagination. Current solution at NASA-PDS/registry-mgr#54 increased the window limit, which may work for now, but sets an arbitrary top bound and the OpenSearch documentation notes that it could affect performance.

Per discussions on that ticket, the OpenSearch scroll API is an option, but would potentially require us to maintain state, which is not RESTful. We need to investigate further to see if there is a solution that can meet both the needs of this requirement while also maintaining the RESTfulness where possible and makes sense

⚖️ Acceptance Criteria

Given
When I perform
Then I expect

⚙️ Engineering Details

@jordanpadams jordanpadams added requirement the current issue is a requirement needs:triage labels Aug 25, 2022
@jordanpadams jordanpadams self-assigned this Aug 25, 2022
@jordanpadams jordanpadams removed their assignment Aug 25, 2022
@jordanpadams jordanpadams transferred this issue from NASA-PDS/registry-mgr Aug 25, 2022
@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Nov 23, 2022

This must work especially with the keyword search for the web UI. This is also preventing the notebook to work.

@alexdunnjpl
Copy link
Contributor

@tloubrieu-jpl @jordanpadams good to close this on the basis of #397, or is the keyword wrinkle keeping it open? Seems like pagination compatibility should be a concern of #430 rather than this ticket

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Aug 8, 2024

This ticket can be closed pagination works and integration tests are proving it.
However, the test have been linked to this ticket NASA-PDS/registry-api/352 rather than the current one.

@github-project-automation github-project-automation bot moved this from ToDo to 🏁 Done in EN Portfolio Backlog Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p.must-have requirement the current issue is a requirement sprint-backlog
Projects
Status: 🏁 Done
Development

No branches or pull requests

3 participants