Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger-ui does not show the expected version #149

Closed
tloubrieu-jpl opened this issue Jun 13, 2022 · 4 comments
Closed

swagger-ui does not show the expected version #149

tloubrieu-jpl opened this issue Jun 13, 2022 · 4 comments
Assignees
Labels
bug Something isn't working s.medium Medium level severity

Comments

@tloubrieu-jpl
Copy link
Member

🐛 Describe the bug

The version of the API does not match something I understand in the swagger-ui.html interface.

image

📜 To Reproduce

Steps to reproduce the behavior:

  1. Go to where the registry-api service deployed, for example http://localhost:8081/
  2. See the swagger-ui.html page where the request is redirected
  3. The version shown in this page is 0.0.1

🕵️ Expected behavior

The version should be either the version of the openapi specification in the swagger.yml file or the version of the implementation in the pom.xml file.

📚 Version of Software Used

1.1.0-SNAPSHOT
1.0.1

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

@tloubrieu-jpl tloubrieu-jpl added bug Something isn't working needs:triage labels Jun 13, 2022
@tloubrieu-jpl tloubrieu-jpl changed the title <system feature> <is not/does not> <expected behaviour> swagger-ui does not show the expected version Jun 13, 2022
@tloubrieu-jpl tloubrieu-jpl added the s.medium Medium level severity label Jun 13, 2022
@al-niessner
Copy link
Contributor

@tloubrieu-jpl

Which version; ./pom.xml or ./service/pom.xml? I notice they are not the same currently. Should they be the same?

@tloubrieu-jpl
Copy link
Member Author

Hi @al-niessner,

The current version should be what is in the ./service/pom.xml and they should be the same. Ideally we should not have a specific version in the service/pom.xml but I did not find a way to have it re-use the parent pom version. I should look into that again.

Anyway, for this ticket you can use the version of the service/pom.xml I guess that makes more sense.

@al-niessner
Copy link
Contributor

@tloubrieu-jpl

There are two possible choices for sharing version numbers in a set of maven modules:

  1. settings
  2. properties

@jordanpadams
Copy link
Member

closed per #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s.medium Medium level severity
Projects
None yet
Development

No branches or pull requests

3 participants