Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lddtool json export seems to export the whole IM, not just the current dictionary #723

Open
msbentley opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels

Comments

@msbentley
Copy link

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When I add the J flag to lddtool, a large json is generated which seems to contain much more than the output of the current dictionary:

image

🕵️ Expected behavior

I expected the -J flag to putput the json for the current dictionary.

📜 To Reproduce

1.
2.
3.
...

🖥 Environment Info

MacOS 14.1.1

📚 Version of Software Used

LDDTool Version: 14.3.0-SNAPSHOT
Built with IM Version: 1.21.0.0
Build Date: 2023-08-23 23:18:03
Configured IM Versions: [1L00, 1K00, 1J00, 1I00, 1H00, 1G00, 1F00, 1E00, 1D00, 1C00, 1B10, 1B00]

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

@github-project-automation github-project-automation bot moved this to ToDo in B15.1 Dec 10, 2024
@jordanpadams jordanpadams changed the title lddtool json export seems to export the whole IM, not just the current dictionary As a user, I just want the JSON returned from LDDTool to include only the current LDD definition Jan 7, 2025
@jordanpadams jordanpadams changed the title As a user, I just want the JSON returned from LDDTool to include only the current LDD definition lddtool json export seems to export the whole IM, not just the current dictionary Jan 7, 2025
@jordanpadams
Copy link
Member

@jshughes is this something that seems reasonable based upon how the IM works? or should we add a flag for this?

@msbentley
Copy link
Author

@jordanpadams @jshughes I should add that we only have this as a step in our dictionary build procedure because originally we understood this was needed for mapping of PDS4 to OpenSearch data types when ingesting data into the registry (otherwise the values end up as string?). As yet we haven't used this in anger, so I guess the questions are:

  • is this still desired with the current registry?
  • is this still the best way to get that mapping into the registry?
  • if yes, does exporting the whole model and feeding this to the registry manager etc. cause conflicts
  • etc. etc.

@jordanpadams jordanpadams removed their assignment Jan 8, 2025
@jordanpadams
Copy link
Member

@msbentley

is this still desired with the current registry?
is this still the best way to get that mapping into the registry?
Yes. The software uses these JSON files to determine the types of all attributes prior to loading it. This enables accurate search.

if yes, does exporting the whole model and feeding this to the registry manager etc. cause conflicts

No. The only way this would be an issue would be if an attribute in the core IM changed datatype, which rarely happens, if ever. Even then, registry manager will just ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Status: ToDo
Development

No branches or pull requests

4 participants