Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDS API has an undocumented hit limit of 10000 (even when not asking for data) #261

Closed
msbentley opened this issue Apr 26, 2023 · 4 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right needs:triage

Comments

@msbentley
Copy link

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When testing queries in the API, I often want to explore the number of products matching a given query, even without looking into the data themselves. e.g. I run a query with limit=0. Doing this for broad queries I reach a cap of 10000 in summary/hits.

  1. I can't obviously find this documented limit in the docs,
  2. there are many use cases for counting products which could run into millions.

Given that we already have the limit keyword, I don't understand why "hits" is limited here and would really like to be able to count products into the millions.

🕵️ Expected behavior

I expected summar/hits of the response to give the accurate number of results for my query, and not an artificial limit.

📜 To Reproduce

r = requests.get(pds_url + 'products',
    params={
        'limit': 0,
        'q': 'pds:Time_Coordinates.pds:start_date_time gt "2001-05-10T00:00:00Z"'})

r.json()['summary']['hits']

This returns 10000

🖥 Environment Info

No response

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

@jordanpadams
Copy link
Member

jordanpadams commented Apr 26, 2023

@alexdunnjpl
Copy link

@jordanpadams regarding docs, does this limit exist in current versions? It shouldn't.

@jordanpadams
Copy link
Member

@msbentley as @alexdunnjpl notes, this will be fixed in ~1-3 weeks. If not, please reopen this bug

@jordanpadams jordanpadams added the invalid This doesn't seem right label Apr 26, 2023
@tloubrieu-jpl
Copy link
Member

We should not have that limit anymore since this ticket NASA-PDS/registry-api#291 is closed. We will investigate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right needs:triage
Projects
None yet
Development

No branches or pull requests

6 participants