Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace summary-only=true by limit=0 #173

Closed
tloubrieu-jpl opened this issue Apr 13, 2022 · 5 comments
Closed

Replace summary-only=true by limit=0 #173

tloubrieu-jpl opened this issue Apr 13, 2022 · 5 comments
Assignees
@jimmie @al-niessner
Labels
B13.0 enhancement New feature or request p.should-have

Comments

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Apr 13, 2022 •
edited by jordanpadams
Loading

💪 Motivation

...so that we don't have this extra parameter. This is also consistent with elasticSearch or solr API behavior for example.

⚙️ Engineering Details
@tloubrieu-jpl tloubrieu-jpl added requirement the current issue is a requirement needs:triage labels Apr 13, 2022
@tloubrieu-jpl tloubrieu-jpl added enhancement New feature or request B13.0 and removed requirement the current issue is a requirement labels Apr 13, 2022
@jordanpadams
Copy link
Member

@tloubrieu-jpl so if I understand this update, we just want to remove the summary-only parameter?

This was referenced Jun 22, 2022
Closed
Closed
@jordanpadams jordanpadams mentioned this issue Jul 21, 2022
Closed
@al-niessner
Copy link
Contributor

Done with PR NASA-PDS/registry-api#166

@jordanpadams jordanpadams mentioned this issue Sep 15, 2022
Closed
@jordanpadams
Copy link
Member

Reverting per issues identified with #179 and difficulty in making it work for all interfaces

@jimmie
Copy link
Contributor

jimmie commented Sep 15, 2022

Worked out a way to do this across the board w/ limit=0. Not the best solution, but it works for now.

@jimmie jimmie self-assigned this Sep 15, 2022
@jimmie jimmie closed this as completed Sep 16, 2022
@jimmie
Copy link
Contributor

jimmie commented Sep 16, 2022

PR approved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmie jimmie

@al-niessner al-niessner

Labels
B13.0 enhancement New feature or request p.should-have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jimmie @al-niessner @jordanpadams @tloubrieu-jpl