Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EIC] Give an option to bring your own STAC API #730

Closed
hanbyul-here opened this issue Nov 2, 2023 · 6 comments
Closed

[EIC] Give an option to bring your own STAC API #730

hanbyul-here opened this issue Nov 2, 2023 · 6 comments
Assignees

Comments

@hanbyul-here
Copy link
Collaborator

EIC will use the datasets from VEDA and GHGC, so there should be ways for the data to bring its stac api endpoint.

Also tagging @danielfdsilva because this will affect new a&e page.

@hanbyul-here hanbyul-here self-assigned this Nov 2, 2023
@j08lue
Copy link
Contributor

j08lue commented Nov 2, 2023

cc @abarciauskas-bgse

Related previous effort: NASA-IMPACT/veda-config#301

@hanbyul-here
Copy link
Collaborator Author

I talked with @slesaad about this issue. I am trying to make a decision between passing STAC endpoint from the dataset level, or having some kinds of dictionories like @slesaad 's implementation there. If NetCDF layer requires its own unique STAC endpoint per dataset, it will make more sense to just pass the stac endpoint from mdx level. Can you give me some insights about this matter? @abarciauskas-bgse

@j08lue
Copy link
Contributor

j08lue commented Nov 2, 2023

just pass the stac endpoint from mdx level

👌 , IMO

@abarciauskas-bgse
Copy link
Contributor

I think these approaches are actually pretty equivalent

  1. The dictionary solution makes it cleaner to reuse catalog endpoints whereas directly passing. We could add the GES DISC cloudstac endpoint to the dictionary approach easily. Another benefit of the dictionary approach is it feels a bit more explicit which catalogs the dashboard supports.
  2. The stac endpoint in the mdx makes it completely transparent what the STAC endpoint is

🤷🏽‍♀️ are there other stakeholders or use cases which might influence this decision?

@j08lue
Copy link
Contributor

j08lue commented Nov 3, 2023

I really do not have a strong opinion on this - we can make any of these choices and still revise it later, if we learn new things.

One argument speaking for MDX-based endpoint specification:

We have before moved away from central config + external reference (in dataset/story config) in the case of dataset filters / tags. The rationale was that maintaining the content in two different places was an obstacle for our content contributors, who were often focused just on the piece of content they were adding, and we would rather sacrifice the better stability / guaranteed consistency of a central config for a more accessible configuration for our users. I think this also applies to catalog endpoints.

So I would say let's go with MDX-based config for now. If it breaks all the time or makes a set of endpoints harder to maintain, we can still pivot. But if you want to make a different call or put together a quick ADR - please do. 😄

@hanbyul-here
Copy link
Collaborator Author

I think we should put more thoughts into introducing a 'catalog' concept to dashboard, so I made the layer responsible to bring their own stacapiendpoint + tileendpoint for now.
Closed via #744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants