Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for terms and privacy policy #336

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Add fields for terms and privacy policy #336

merged 4 commits into from
Sep 2, 2021

Conversation

mplsmitch
Copy link
Collaborator

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

The specification lacks a way to express terms of service and privacy policy information. Related closed PR: #254

What is the proposal?

This proposal adds optional fields to system_information.json to hold URLs for the system terms of service and the privacy policy for the service. Along with these there are optional fields to contain the dates when these policies were last modified.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

gbfs.md:

  • system_information.json

Adds fields for terms of service and privacy policy for the system
@heidiguenin heidiguenin added proposal:nonbreaking v2.3 Candidate change for v2.3 (minor release) labels Aug 16, 2021
@mplsmitch
Copy link
Collaborator Author

I hereby call a vote on this proposal.

Voting will be open for 10 full calendar days until 11:59PM UTC on September 1st, 2021.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@kanagy
Copy link

kanagy commented Aug 23, 2021

Google Maps supports this proposal, but we don't plan on ingesting and using the new fields yet.

Nit: Could you make the date format consistent? The example for system_information says "start_date": "2010-06-10" (i.e. using hyphen as date separator). It would be nice to extend the example too with privacy & terms fields.

changes terms date format from slash to hyphen separator
@richtaylor-ito
Copy link
Contributor

Ito World supports this proposal.

@nbdh
Copy link
Contributor

nbdh commented Aug 26, 2021

Nextbike supports this proposal and we would add those fields to our feeds in the future.

@dirkdk
Copy link
Contributor

dirkdk commented Aug 26, 2021

Google Maps supports this proposal, but we don't plan on ingesting and using the new fields yet.

Nit: Could you make the date format consistent? The example for system_information says "start_date": "2010-06-10" (i.e. using hyphen as date separator). It would be nice to extend the example too with privacy & terms fields.

I agree with the date format consistency. It would probably be best to have a higher level definition of date formatting somewhere that we can always refer back to. This would improve consistency

@viestat
Copy link
Contributor

viestat commented Aug 27, 2021

Dott supports this proposal, we could add this in the near future.

@evansiroky
Copy link
Contributor

IBI Group supports this proposal.

@cait32
Copy link

cait32 commented Sep 1, 2021

BCycle supports this proposal and we would add it to our feeds in the future.

@ncancelliere
Copy link

Spin support this proposal, and we would likely implement this in our feeds.

@ezmckinn
Copy link
Contributor

ezmckinn commented Sep 1, 2021

Superpedestrian supports this addition, and we would add it to our GBFS feeds.

@josee-sabourin
Copy link
Contributor

This vote is now closed, and it passes!

Votes in favour:
Google Maps (consumer)
Ito World (producer)
Dott (producer)
IBI Group (consumer)
BCycle (producer)
Spin (producer)
Superpedestrian (producer)

There we no votes against.

Regarding @kanagy's and @dirkdk comment: We will make that change when we merge this into v2.3-RC, thanks for the input!

Mitch Vars added 2 commits September 2, 2021 11:49
Further defines `date` field format as ISO 8601 calendar date extended.
Labels new fields as added in v2.3
@mplsmitch mplsmitch merged commit 59fbd79 into master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md proposal:nonbreaking v2.3 Candidate change for v2.3 (minor release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.