Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors issue with THREE.js r156 #18

Closed
LR17 opened this issue Sep 29, 2023 · 12 comments
Closed

Colors issue with THREE.js r156 #18

LR17 opened this issue Sep 29, 2023 · 12 comments

Comments

@LR17
Copy link

LR17 commented Sep 29, 2023

Hello,
I've been using N8AO with THREE.js r150.
After upgrade to THREE.js r156 the colors are washed out, is there anything that can be done on my side or is it an incompatibility with this release?

@LR17 LR17 changed the title Colors issue with THREE.js r 156 Colors issue with THREE.js r156 Sep 29, 2023
@N8python
Copy link
Owner

N8python commented Oct 5, 2023

Try turning gamma correction off.

@LR17
Copy link
Author

LR17 commented Oct 9, 2023

Unfortunately it does not help. Also tried creating my own beauty render target but without success

@N8python
Copy link
Owner

Try on the pass itself - configuration.gammaCorrection

@LR17
Copy link
Author

LR17 commented Oct 12, 2023

That's the property I set, but does not help

@N8python
Copy link
Owner

Very strange. What is the color space of your render target - could you perhaps share your code?

@LR17
Copy link
Author

LR17 commented Oct 13, 2023

this.effectComposer = new THREEX.EffectComposer(this.renderer);
this.effectComposerSSAOPass = new N8AOPass(this.scene, this.perspectiveCamera, width, height);
this.effectComposerSSAOPass.configuration.gammaCorrection = false;
this.effectComposerOutputPass = new THREEX.OutputPass();

this.effectComposer.addPass(this.effectComposerSSAOPass);
this.effectComposer.addPass(this.effectComposerOutputPass);

@N8python
Copy link
Owner

N8python commented Oct 16, 2023

Is the threeX output pass doing gamma correction where it shouldn't? Which version of n8ao does ThreeX use?

@LR17
Copy link
Author

LR17 commented Oct 20, 2023

Hello,
THREEX is an alias to import three/examples/jsm, using three r156 and n8ao 1.6.8
OutputPass is doing tone mapping and colorspace conversion

@N8python
Copy link
Owner

Strange. I am geniunely not sure what could be causing this. Try it without OutputPass maybe?

@CodyJasonBennett
Copy link
Contributor

This is likely from r155 where in mrdoob/three.js#26371, when rendering to a render target, tone-mapping is internally disabled. You're expected to now include a tonemapping or output pass when using post-processing.

@N8python
Copy link
Owner

N8AO automatically gamma corrects (this can be disabled)... so it shouldn't be an issue with the library.

@N8python
Copy link
Owner

Closing due to inactivity. Reopen if the issue is still relevant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants