-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors issue with THREE.js r156 #18
Comments
Try turning gamma correction off. |
Unfortunately it does not help. Also tried creating my own beauty render target but without success |
Try on the pass itself - configuration.gammaCorrection |
That's the property I set, but does not help |
Very strange. What is the color space of your render target - could you perhaps share your code? |
|
Is the threeX output pass doing gamma correction where it shouldn't? Which version of n8ao does ThreeX use? |
Hello, |
Strange. I am geniunely not sure what could be causing this. Try it without OutputPass maybe? |
This is likely from r155 where in mrdoob/three.js#26371, when rendering to a render target, tone-mapping is internally disabled. You're expected to now include a tonemapping or output pass when using post-processing. |
N8AO automatically gamma corrects (this can be disabled)... so it shouldn't be an issue with the library. |
Closing due to inactivity. Reopen if the issue is still relevant! |
Hello,
I've been using N8AO with THREE.js r150.
After upgrade to THREE.js r156 the colors are washed out, is there anything that can be done on my side or is it an incompatibility with this release?
The text was updated successfully, but these errors were encountered: