Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD buillds post Software Sources version bump #91

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

ptheywood
Copy link
Member

#67 increased the sphinx version to no longer be several major version behind.

This change resulted in the RTD build failing, due to the use of a deprecated and removed sphinx function, which was only called when building on RTD.

This PR:

  • Adjusts the GitHub Actions workflow to run as if it were an RTD build (i.e. it defines the required environment variable to trigger the behaviour)
  • Fixes the error

@ptheywood ptheywood force-pushed the split-software-rtd-fixes branch 2 times, most recently from e37a8b2 to a5d36ed Compare February 8, 2022 11:25
@ptheywood
Copy link
Member Author

CI for a5d36ed failed as intended, demonstrating CI now reproduces RTD behaviour (build log)

While e37a8b2 passed, so this should now fix our RTD builds.

@ptheywood ptheywood marked this pull request as ready for review February 8, 2022 11:27
@ptheywood ptheywood merged commit fd63639 into main Feb 8, 2022
@ptheywood ptheywood deleted the split-software-rtd-fixes branch February 8, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants