Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastx adapter] choose gas costs #81

Closed
sblackshear opened this issue Dec 21, 2021 · 7 comments
Closed

[fastx adapter] choose gas costs #81

sblackshear opened this issue Dec 21, 2021 · 7 comments
Assignees
Labels
move Triaged Issue is associated with a milestone and has at least 1 label of each: status, type, & priority

Comments

@sblackshear
Copy link
Collaborator

There are two kinds of costs for us to reflect: computation, and storage. Some decisions to be made:

Storage

  1. How much do we charge per byte of storage?
  2. Do we charge only for the storage of the order itself, or also for the storage of the objects it creates?
  3. What should the upper limit on the size of transactions be?
  4. What should the upper limit on the total size of objects created by a transaction be?
  5. What should the upper limit on the size of an individual object be?

Computation

  1. The Move VM allows us to configure the gas costs of individual bytecode instructions. What values should we choose?
  2. What should we choose for the gas costs of native order types (e.g., transfer)?
@gdanezis
Copy link
Collaborator

These are all great questions. But they have no principled technical answers, since they are resource allocation problems based on the (potentially diverging) preferences of validators.

So I think the overall questions could be:

  • How do we determine, in any epoch / at any point in time, what the costs should be?
  • What mechanisms do we need to coordinate this determination?
  • Do all need to agree on these costs? (I think yes? Hm, maybe.)
  • How dynamically can we modify these costs? Per-validator, per-epoch, more frequently?

This is a place where I would loop in our economist while they join. Right now lets just use placeholder defaults.

@gdanezis gdanezis changed the title [fastx adapter] choose gas costs [fastx adapter] choose gas costs (Design Task) Jan 13, 2022
@gdanezis
Copy link
Collaborator

I would also add to the items for which we should charge:

  • We should include a charge in gas according to the length of the mutable inputs of a transaction.

@lxfind lxfind changed the title [fastx adapter] choose gas costs (Design Task) [fastx adapter] choose gas costs Jan 21, 2022
@lxfind lxfind added this to the TBD milestone Jan 21, 2022
@gdanezis
Copy link
Collaborator

We are now coordinating all econ related questions with alonso, here, including gas: https://docs.google.com/presentation/d/1LM5zVtLG64Ny4Q8oxSf9R3tfGsxmdKGbPIUSEaH-f3E/edit?usp=sharing

@666lcz
Copy link
Contributor

666lcz commented Feb 21, 2022

related: #248

@bholc646 bholc646 removed this from the TBD milestone Apr 6, 2022
@gdanezis gdanezis added this to the TestNet milestone Apr 19, 2022
@sblackshear sblackshear added move Triaged Issue is associated with a milestone and has at least 1 label of each: status, type, & priority labels Apr 21, 2022
@lxfind lxfind modified the milestones: TestNet, [A] Private Testing Jul 2, 2022
@bholc646
Copy link
Contributor

Can this be closed @oxade?

@bholc646
Copy link
Contributor

I'm guessing most of this has to be figured out or is captured directly in #1122

@oxade oxade self-assigned this Aug 31, 2022
@oxade
Copy link
Contributor

oxade commented Aug 31, 2022

Can this be closed @oxade?

@bholc646 I'll consolidate all the issues

@oxade oxade closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
move Triaged Issue is associated with a milestone and has at least 1 label of each: status, type, & priority
Projects
None yet
Development

No branches or pull requests

6 participants