Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing a vector of objects in Move calls #492

Closed
lxfind opened this issue Feb 20, 2022 · 8 comments · Fixed by #4349
Closed

Support passing a vector of objects in Move calls #492

lxfind opened this issue Feb 20, 2022 · 8 comments · Fixed by #4349

Comments

@lxfind
Copy link
Contributor

lxfind commented Feb 20, 2022

Currently a Move order only supports a list of individual objets as each object parameter. We should also support having a vector of objects as individual parameter.

@lxfind lxfind added the move label Feb 20, 2022
@lxfind lxfind added this to the GDC milestone Feb 20, 2022
@oxade oxade self-assigned this Feb 28, 2022
@oxade
Copy link
Contributor

oxade commented Feb 28, 2022

Will take a look at this
I reckon I just have the leverage the new Collection type right?

@lxfind
Copy link
Contributor Author

lxfind commented Mar 29, 2022

Will take a look at this I reckon I just have the leverage the new Collection type right?

Just saw the comment. For this we should be using the Move native vector type.

@bholc646 bholc646 removed this from the GDC milestone Apr 6, 2022
@bholc646 bholc646 removed the move label Apr 6, 2022
@gdanezis gdanezis added this to the Mainnet milestone Apr 19, 2022
@oxade
Copy link
Contributor

oxade commented May 10, 2022

Depends on #1521

@oxade
Copy link
Contributor

oxade commented May 10, 2022

Spoke to @tnowacki and we have a general plan for this

@sblackshear sblackshear added the Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering label May 23, 2022
@oxade oxade assigned tnowacki and unassigned oxade May 23, 2022
@oxade
Copy link
Contributor

oxade commented May 23, 2022

Handing off to @tnowacki who has more context on adapter side #1521

@oxade
Copy link
Contributor

oxade commented May 23, 2022

Major areas that need to be updated:

  1. RPC: we need to modify the RPC layer to take a vec of object IDs
  2. CLI: vectors of object IDs will probably need to be fleshed out for better UX
  3. Adapter: we make assumptions of the number of objects going into a TX being the number of objects in the fn signature, but we cannot guarantee this with objects.

Other things of note:

  1. Error reporting: when an inner object in a vec has an error for example due to locking or type mismatch, we need to propagate that clearly
  2. The checker needs to be improved to check all items in the vector quickly since vectors can be large

@lxfind lxfind modified the milestones: [G] Mainnet, [B] Wave 1 Jul 3, 2022
@lxfind lxfind removed the Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering label Jul 6, 2022
@bholc646
Copy link
Contributor

@lxfind @tnowacki I think we just said in our planning meeting that this is a duplicate of #1521 but this discussion from 3+ months ago makes it sound like it is different and in fact dependent on #1521. Can someone clarify?

@lxfind
Copy link
Contributor Author

lxfind commented Aug 11, 2022

It's pretty much the same thing, can definitely merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants