From 9acc021253632734e31b2e06eb14036b3ad4db5f Mon Sep 17 00:00:00 2001 From: Robert McLaughlin Date: Fri, 29 Nov 2024 09:43:33 -0800 Subject: [PATCH] Fix: fullnode template ipv4 docs (#20452) ## Description Fixes the fullnode template: incorrect documentation on how to set ipv4 address. See reference: [sui/creates/sui-config/src/node.rs:478](https://github.com/MystenLabs/sui/blob/8bd53998f88c4619f39dcf298f699199a0071e7c/crates/sui-config/src/node.rs#L478) ## Test plan How did you test the new or updated feature? Set the configuration value on a locally running node. Setting to `/ipv4/...` crashes on boot. Setting to `/ip4/...` continues to boot. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --- crates/sui-config/data/fullnode-template-with-path.yaml | 4 ++-- crates/sui-config/data/fullnode-template.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/sui-config/data/fullnode-template-with-path.yaml b/crates/sui-config/data/fullnode-template-with-path.yaml index 07ac7e7f5dd7e..817b2f2fc5689 100644 --- a/crates/sui-config/data/fullnode-template-with-path.yaml +++ b/crates/sui-config/data/fullnode-template-with-path.yaml @@ -1,7 +1,7 @@ # Update this value to the location you want Sui to store its database db-path: "suidb" -# For ipv4, update this to "/ipv4/X.X.X.X/tcp/8080/http" +# For ipv4, update this to "/ip4/X.X.X.X/tcp/8080/http" network-address: "/dns/localhost/tcp/8080/http" metrics-address: "0.0.0.0:9184" # this address is also used for web socket connections @@ -27,4 +27,4 @@ network-key-pair: account-key-pair: path: "account.key" worker-key-pair: - path: "worker.key" \ No newline at end of file + path: "worker.key" diff --git a/crates/sui-config/data/fullnode-template.yaml b/crates/sui-config/data/fullnode-template.yaml index a3c580a86d5e5..eef3f3acaec11 100644 --- a/crates/sui-config/data/fullnode-template.yaml +++ b/crates/sui-config/data/fullnode-template.yaml @@ -1,7 +1,7 @@ # Update this value to the location you want Sui to store its database db-path: "/opt/sui/db" -# For ipv4, update this to "/ipv4/X.X.X.X/tcp/8080/http" +# For ipv4, update this to "/ip4/X.X.X.X/tcp/8080/http" network-address: "/dns/localhost/tcp/8080/http" metrics-address: "0.0.0.0:9184" # this address is also used for web socket connections