Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

Cleanup Network #566

Closed
asonnino opened this issue Jul 22, 2022 · 1 comment · Fixed by #687
Closed

Cleanup Network #566

asonnino opened this issue Jul 22, 2022 · 1 comment · Fixed by #687
Assignees
@asonnino
Labels
bug Something isn't working

Comments

@asonnino
Copy link
Contributor

Description

Most of our networks (PrimaryToWorkerNetwork, PrimaryNetwork, WorkerNetwork) have a HashMap of address -> clients. When the committee changes and the network addresses change, the networks will simply expand this hash map but it is never cleaned up.
@asonnino asonnino added the bug Something isn't working label Jul 22, 2022
@asonnino asonnino self-assigned this Jul 22, 2022
@huitseeker
Copy link
Contributor

And we introduced a parallel HashMap of BoundedExecutors in #559 indeed.

@asonnino asonnino linked a pull request Aug 4, 2022 that will close this issue
Fix network memory leaks #687
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@asonnino asonnino

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix network memory leaks MystenLabs/narwhal
2 participants
@huitseeker @asonnino