Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal error for short custom SSID repeater after Android 10 March 2020 security patch #153

Closed
Mygod opened this issue Mar 15, 2020 · 8 comments
Labels
vendor-specific Definitely not my fault

Comments

@Mygod
Copy link
Owner

Mygod commented Mar 15, 2020

Shit.

@SykkNyzz
Copy link

SykkNyzz commented Mar 15, 2020

Only thing I can offer is that creating a password works in PDAnet (Android 10) Even though you can't pick your own SSID. Idunno if that helps you towards your goal.

@Mygod
Copy link
Owner Author

Mygod commented Mar 15, 2020

It's only going to work if your SSID starts with DIRECT-xy, no?

@SykkNyzz
Copy link

Screenshot_20200315-174214_1
Apparently that seems to be the case.

@SykkNyzz
Copy link

Screenshot_20200315-175038
Well, that's good to know.

@Mygod Mygod changed the title internal error for custom SSID repeater after Android 10 March 2020 security patch internal error for short custom SSID repeater after Android 10 March 2020 security patch Mar 18, 2020
@Mygod
Copy link
Owner Author

Mygod commented Mar 18, 2020

It seems like actually SSID has to be at least 9 characters long instead of having to conform to "DIRECT-xy". This is the commit that broke it: https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/221cd9e93b94def60aa4a5adbdd3bfa91502bdc8%5E%21/

@Mygod
Copy link
Owner Author

Mygod commented Mar 18, 2020

A patch reverting the change has been submitted: https://android-review.googlesource.com/c/platform/frameworks/opt/net/wifi/+/1261161

Y'all are welcome to go there and +1.

@Mygod
Copy link
Owner Author

Mygod commented Mar 24, 2020

Please also go star this issue at Google: https://issuetracker.google.com/issues/152250230

The best way to fix this is to get Google to revert their changes.

@Mygod Mygod added the vendor-specific Definitely not my fault label Apr 22, 2020
@Mygod Mygod closed this as completed in 3ba9a32 Apr 22, 2020
@Mygod
Copy link
Owner Author

Mygod commented Apr 22, 2020

If you are using Android 10 March 2020 security patch or newer, in the next update, you will see an option to turn off "Repeater safe mode", this will enable the "legacy behavior" that you would get on Android 9- but short SSIDs work according to my test.

Turning it off means all the caveats from the legacy behavior; see also: #8 (comment), #31.

P.S. It is not necessary to turn off safe mode if you do not encounter "internal errors". A more reliable way to tell whether your ROM has this "feature" merged would be to look at ro.system.build.id and see if the second segment is at least 200305.

This commit is known to be contained in android-10.0.0_r30, android-r-preview-2 or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-specific Definitely not my fault
Projects
None yet
Development

No branches or pull requests

2 participants