Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence on localstorage #795

Closed
futurepaul opened this issue Oct 14, 2023 · 2 comments · Fixed by #757
Closed

Remove dependence on localstorage #795

futurepaul opened this issue Oct 14, 2023 · 2 comments · Fixed by #757

Comments

@futurepaul
Copy link
Contributor

In order to run in a service worker we need to not call localstorage from mutiny-node (or at least make it optional).
@benthecarman
Copy link
Collaborator

In #757 I added a commit that makes it if you enable the feature service-worker it'll skip local storage

@benthecarman benthecarman linked a pull request Oct 15, 2023 that will close this issue
Windowless sleep #757
Merged
@TonyGiorgio
Copy link
Contributor

Can't we just remove it completely now though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windowless sleep MutinyWallet/mutiny-node
3 participants
@futurepaul @benthecarman @TonyGiorgio