Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on GLMakie or Makie? #23

Closed
timholy opened this issue May 13, 2024 · 2 comments
Closed

Depend on GLMakie or Makie? #23

timholy opened this issue May 13, 2024 · 2 comments

Comments

@timholy
Copy link
Contributor

timholy commented May 13, 2024

All the core types and functions of the Makie ecosystem are defined in Makie itself. I'd propose this package should depend only on Makie, and then the rendering can be done in any backend (GLMakie, CairoMakie, WGLMakie, or RPRMakie) of the user's choosing. This would be a breaking change, as users would be required to use using GLMakie, ProtPlot to reproduce current behavior rather than just using ProtPlot.

Thoughts? I'm happy to make this change if the maintainers are on board.

@AntonOresten
Copy link
Member

AntonOresten commented May 14, 2024

This makes sense. I'm currently cleaning up and rewriting the package to improve the ribbon shapes, and to take advantage of Makie.jl recipes (#25), so I've already implemented this on the recipes branch (WIP, doesn't compile yet). Should be ready soon.😊

@AntonOresten
Copy link
Member

This has now been implemented in v0.4.0.
I'm excited about some more robust and improved visuals, and the package aligning more with how Makie is supposed to be used.
Note that the Makie recipe defines ribbon and ribbon! on its own, so the scene and camera stuff was moved to ribbon_scene for convenience. ribbon now only makes some 2D projection onto an Axis.

Thank you for opening this issue!😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants