Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

felsenstein_down! on polytomies #29

Open
nossleinad opened this issue Jun 19, 2024 · 0 comments
Open

felsenstein_down! on polytomies #29

nossleinad opened this issue Jun 19, 2024 · 0 comments

Comments

@nossleinad
Copy link
Collaborator

felsenstein_down! uses a nested loop over children and siblings for combine! ops. This is fine for binary trees but very slow (quadratic time complexity, with respect to children) for polytomies. Since a polytomy is equivalent to a binary tree with some added internal nodes with 0 branchlength, we can improve here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant