You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a discrepancy of encodings of discrete states:
IndependentDiscreteDiffusion assumes the state x is encoded with one-hot encoding.
UnifromDiscreteDiffusion assumes the state x is encoded with integers from 1 to #{number of states}.
We should unify the encodings so that different diffusions can be used interchangeably.
I think encoding states with integers from 1 to #{number of states} would be better here because it is simpler and we can drop the dependency on OneHotArrays.jl, which makes the package more light.
The text was updated successfully, but these errors were encountered:
This was intentional. There are potential experimental uses that exploit the fact that IndependentDiscreteDiffusion can handle uncertainty, such as using the expected probabilities instead of a sample as x0. This doesn't recover the target, but could do other interesting things, and we don't want to rule it out. It also makes the closed form stuff from the example simpler, which is useful for asking questions about convergence etc. Also, I expect almost all standard use cases will involve UnifromDiscreteDiffusion as a default, and not have to worry about this consistency, and we can leave IndependentDiscreteDiffusion for advanced use. I'd take it out of the example, except I want the closed form version in there for now.
There is a discrepancy of encodings of discrete states:
IndependentDiscreteDiffusion
assumes the statex
is encoded with one-hot encoding.UnifromDiscreteDiffusion
assumes the statex
is encoded with integers from 1 to #{number of states}.We should unify the encodings so that different diffusions can be used interchangeably.
I think encoding states with integers from 1 to #{number of states} would be better here because it is simpler and we can drop the dependency on OneHotArrays.jl, which makes the package more light.
The text was updated successfully, but these errors were encountered: