Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch v0.23 for compatibility with latest NumPy #1

Closed
dmitrisvetlov opened this issue Jul 9, 2024 · 0 comments · Fixed by #2
Closed

Patch v0.23 for compatibility with latest NumPy #1

dmitrisvetlov opened this issue Jul 9, 2024 · 0 comments · Fixed by #2
Assignees
Labels
bug Something isn't working

Comments

@dmitrisvetlov
Copy link
Contributor

For reasons that are not entirely clear, the latest version of pycro-manager (v0.34.8 or thereabouts) does not work with our terminator code, and I have heard from colleagues that there may be a bug (identical or different) in that code that is more general. As a result, for the near term it is worthwhile to stick with pycro-manager v0.23, and the corresponding (somewhat old) version of Micro-Manager.

However, this causes a problem for our conda environment, because this old version of pycro-manager is incompatible with the latest version of numpy, which understandably causes artificial version incompatibilities with other packages, some of which can be difficult and time-consuming to diagnose and resolve. (The incompatibility is due to the fact that the old np.bool type was deprecated before 1.24.0 of numpy in favor of the built-in bool (to which it was just an alias). It will return, however, in 2.0.0, as numpy.bool, as indicated in the release notes; see also relevant pull request.)

As a result, we will do the following:

  1. Revert this fork of pycro-manager to v0.23, i.e. this commit.
  2. Create a patch, v0.23.1, to remove the incompatibility with the latest version of numpy. NOTE: Although v2.0.0 has been released (on June 17, 2024), the latest version in conda remains at v1.26.4.
  3. We will reintegrate this into main and only update this fork for one of two reasons: to make subsequent fixes necessary as numpy is updated further, or to upgrade to newer versions of pycro-manager once the underlying bug(s) have been fixed upstream.
  4. In our terminator repository, we will update the environment to install this version of pycro-manager rather than the one available via pip. NOTE: To ensure optimum compatibility with the Java bridge, this requires utilizing a specific Micro-Manager version; namely, the December 18, 2022 nightly build.
@dmitrisvetlov dmitrisvetlov self-assigned this Jul 9, 2024
@dmitrisvetlov dmitrisvetlov added the bug Something isn't working label Jul 9, 2024
@dmitrisvetlov dmitrisvetlov linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant