Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation for custom_arguments passed to Fog. #7

Closed
wants to merge 5 commits into from

Conversation

prabhu-das
Copy link

Please confirm this approach.
Currently we pass the arguments with --custom-arguments "provider=openstack" format. Here provider is an actual attribute supported by Fog.
Thanks.

@@ -30,6 +30,7 @@ def load_fog_gem

def connection
add_api_endpoint
add_custom_arguments
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this gets us -- do you know of cases where initiating the Fog service connection with extra parameters gets us additional functionality?

@adamedx
Copy link

adamedx commented Nov 22, 2013

So the idea here is that for every command, you can pass additional options -- these will not be validated, and may be ignored, and may cause unknown behavior. But the idea here is that if you know something about the underlying provider, you can still get the benefits of one-stop shopping with a chef + cloud provider integration -- no need to write a wrapper script to create vm's and then chef them up.

To be sure we're on the same page, can you post an example command line (real-world) for say OpenStack -- e.g. knife openstack server create that lets us do something with openstack that we can't do currently with knife openstack but is supported by Fog?

@prabhu-das
Copy link
Author

I have updated JIRA (OC- 10611) with a real time example for custom_arguments passed to Fog, that is not supported by knife-cloud.
Please review and let me know if we can apply similar changes for server list, image list and server delete.

@prabhu-das
Copy link
Author

Reopening new PR to opscode master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants