Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(icd): better image crop divide node #2

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Conversation

MrLixm
Copy link
Owner

@MrLixm MrLixm commented Dec 8, 2023

Refactoring on the node mainly on the code side.

New user feature are the option to combine the crops after writing them, using a button on the node for a faster workflow.

developer changes

  • add proper logic of "build" for the node.
  • refactoring of the crop generation script that should be simpler (less OOP :p)

user changes

  • better default value for the knobs
  • option to auto-combine combine the crops once exported manually
  • better node UI with more instructions

@MrLixm MrLixm added the enhancement New feature or request label Dec 8, 2023
@MrLixm MrLixm self-assigned this Dec 8, 2023
@MrLixm MrLixm merged commit aa2784d into main Dec 12, 2023
@MrLixm MrLixm deleted the refacto-image-crop-divide branch December 12, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant