privacy.resistFingerprinting.block_mozAddonManager

[laniakea64]

Fixes #441

[jbeich]

If not too hard consider backporting all commits from the specific Mozilla bug. While tests aren't immediately useful they can help troubleshooting cherry-picking mistakes.

[laniakea64]

@jbeich Done, but it's broken due to testing/marionette/assert.js explicitly requiring Firefox. Changing isFirefox to check for Waterfox gets it to go, but I'm not sure if that's enough to really fix it. I don't know this test stuff well at all 😕

[MrAlex94]

This should work without a problem.

[MrAlex94]

@laniakea64, I don't believe I've changed any of the actual internal variables named Firefox, except in relation to the registry and the branding files. Do you receive any errors running marionette tests?

[laniakea64]

This command...

./mach mochitest -f browser browser/components/resistfingerprinting/test

... just chokes -

Traceback (most recent call last):
  File "/srv/waterfox/Waterfox/objdir/_tests/testing/mochitest/runtests.py", line 2540, in doTests
    marionette_args=marionette_args,
  File "/srv/waterfox/Waterfox/objdir/_tests/testing/mochitest/runtests.py", line 2148, in runApp
    os.path.join(here, 'extensions', 'specialpowers')
  File "/srv/waterfox/Waterfox/testing/marionette/client/marionette_driver/addons.py", line 50, in install
    return self._mn._send_message("addon:install", body, key="value")
  File "/srv/waterfox/Waterfox/testing/marionette/client/marionette_driver/decorators.py", line 23, in _
    return func(*args, **kwargs)
  File "/srv/waterfox/Waterfox/testing/marionette/client/marionette_driver/marionette.py", line 739, in _send_message
    self._handle_error(err)
  File "/srv/waterfox/Waterfox/testing/marionette/client/marionette_driver/marionette.py", line 772, in _handle_error
    raise errors.lookup(error)(message, stacktrace=stacktrace)
UnsupportedOperationException: Only supported in Firefox
stacktrace:
        WebDriverError@chrome://marionette/content/error.js:227:5
        UnsupportedOperationError@chrome://marionette/content/error.js:532:5
        assert.that/<@chrome://marionette/content/assert.js:383:13
        assert.firefox@chrome://marionette/content/assert.js:65:3
        GeckoDriver.prototype.installAddon@chrome://marionette/content/driver.js:3190:3
        execute/req<@chrome://marionette/content/server.js:539:22
        TaskImpl_run@resource://gre/modules/Task.jsm:331:42
        TaskImpl@resource://gre/modules/Task.jsm:280:3
        asyncFunction@resource://gre/modules/Task.jsm:252:14
        Task_spawn@resource://gre/modules/Task.jsm:166:12
        execute@chrome://marionette/content/server.js:529:15
        onPacket@chrome://marionette/content/server.js:500:7
        _onJSONObjectReady/<@chrome://marionette/content/transport.js:501:9

0 ERROR Automation Error: Received unexpected exception while running application

Stopping web server
Stopping web socket server
Stopping ssltunnel
leakcheck | refcount logging is off, so leaks can't be detected!
runtests.py | Running tests: end.
Buffered messages finished
TEST-INFO | checking window state
Browser Chrome Test Summary
        Passed: 0
        Failed: 0
        Todo: 0
        Mode: e10s
*** End BrowserChrome Test Results ***
Buffered messages finished
SUITE-END | took 15s

If https://github.com/MrAlex94/Waterfox/blob/master/testing/marionette/assert.js#L25 is changed to check for Waterfox, the command runs.