Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deadlock in Sapphire #454

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Avoid deadlock in Sapphire #454

merged 3 commits into from
Jun 18, 2024

Commits on Jun 17, 2024

  1. [sapphire] Fix test coverage and nits

    @tysmith
    tysmith committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    91483d8 View commit details
    Browse the repository at this point in the history

  2. [sapphire] Improve port validation

    @tysmith
    tysmith committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    450b3ea View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. [sapphire] Set listening socket to non-blocking 

    This will prevent a hang due to race between select() and accept().
    @tysmith @jschwartzentruber
    tysmith authored and jschwartzentruber committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f758e3e View commit details
    Browse the repository at this point in the history