Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #110 - Folder structure overhaul #135

Merged
merged 73 commits into from
Oct 19, 2017
Merged

Fix #110 - Folder structure overhaul #135

merged 73 commits into from
Oct 19, 2017

Conversation

nth10sd
Copy link
Contributor

@nth10sd nth10sd commented Sep 18, 2017

This fixes #110 - it overhauls the folder structure of funfuzz completely and makes it installable as a pip module. A lot of changes are fairly mechanical.

We should ideally first release 0.1.0 as an initial legacy version with all the old path structure, similar to Lithium. (DONE)

To be updated later in this PR: (DONE)
* Update scripts to no longer execute *.py files directly, but instead as a module
* Update documentation with how-to-run

Next steps (outside of this PR):

nth10sd added 30 commits August 31, 2017 09:04
@nth10sd
Copy link
Contributor Author

nth10sd commented Sep 20, 2017

For the main python -m funfuzz issue, I will merely exit now if the zip file of signatures is not found locally or via Collector. Ideally, the signatures should be found, ~/trees/mozilla-central should be present, then fuzzing will continue via compilation. Or if the latter isn't available, downloaded shells will be used (this relies on upcoming fuzzfetch integration). This could be done better, but it's a hotfix for now.

For the loop issue, there is a missing argument. It should be:

python -m funfuzz.js.loop --random-flags 20 ANYTHING $tmd

ANYTHING is not actually used by anything now, it will be ripped out when I subsequently move to argparse.

I will re-request review only I finish the following to-dos: the loop_bot issue as well as the following notes to self:

ag --ignore=tooltool/ --ignore=util/ --ignore=after-fix.txt --ignore=shell_flags.py --ignore=gen-grammar.js --ignore=known_broken_earliest_working '\.py'
ag '\.py'

@jschwartzentruber
Copy link
Collaborator

Looks good to me. I did minimal testing but I did let it compile and run and didn't see any issues. Have you let it run long enough to exercise the lithium integration? Reported to FuzzManager?

Copy link
Collaborator

@jschwartzentruber jschwartzentruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ conditional on confirming funfuzz.bot runs through reduction and reporting to FM without issue.

@nth10sd
Copy link
Contributor Author

nth10sd commented Oct 19, 2017

funfuzz.bot now runs through reduction and reports to FM without issue.

@nth10sd nth10sd merged commit 9fcc702 into master Oct 19, 2017
@nth10sd nth10sd deleted the imports-overhaul branch October 19, 2017 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[funfuzz] funfuzz should be installable
2 participants