Avoid failures when trying to remove missing directories

src/ffpuppet/main.py

@@ -343,5 +343,5 @@ def main(argv: Optional[List[str]] = None) -> None:  # pylint: disable=missing-d
         if ffp.reason == Reason.ALERT or args.save_all:
             LOG.info("Browser logs available here '%s'", logs.resolve())
         else:
-            rmtree(logs)
+            rmtree(logs, ignore_errors=True)
         ffp.clean_up()

src/ffpuppet/profile.py

@@ -52,7 +52,8 @@ def __init__(
                 for cert in cert_files:
                     self._install_cert(cert, certutil_find(browser_bin))
         except Exception:
-            rmtree(self.path, onerror=onerror)
+            if self.path.exists():
+                rmtree(self.path, onerror=onerror)
             raise
 
     def __enter__(self) -> "Profile":
@@ -228,9 +229,11 @@ def remove(self, ignore_errors: bool = True) -> None:
             None
         """
         if self.path:
-            LOG.debug("removing profile")
             try:
-                rmtree(self.path, onerror=onerror)
+                # check if path exists to properly support "onerror"
+                if self.path.exists():
+                    LOG.debug("removing profile")
+                    rmtree(self.path, onerror=onerror)
             except OSError:
                 LOG.error("Failed to remove profile '%s'", self.path)
                 # skip raising here instead of passing ignore_errors to rmtree

src/ffpuppet/puppet_logger.py

@@ -102,12 +102,15 @@ def clean_up(self, ignore_errors: bool = False) -> None:
         """
         if not self.closed:
             self.close()
-        if self.path is not None and self.path.is_dir():
-            for attempt in range(2):
+        if self.path is not None:
+            # try multiple attempts to remove data
+            for attempt in reversed(range(2)):
                 try:
-                    rmtree(self.path, ignore_errors=ignore_errors, onerror=onerror)
+                    # check if path exists to properly support "onerror"
+                    if self.path.exists():
+                        rmtree(self.path, ignore_errors=ignore_errors, onerror=onerror)
                 except OSError:
-                    if attempt > 0:
+                    if attempt == 0:
                         warn_open(self.path)
                         raise
                     continue