Add support for popup blocking UI

[bluemarvin]

Hardware

All

Current Behavior

All popups are blocked.

Expected Behavior

user should be prompted if a popup should be blocked.

Possible Solution

GeckoView added a popup request the dialog delegate. FxR should add support for this so users can decide if a popup should be blocked. This should allow users to log in with facebook on 3rd party websites.

[caseyyee]

Flagging for UX, we'll need to look at doorhanger UI behavior for blocked popups.

[philip-lamb]

Implement interface https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/GeckoSession.PromptDelegate.html#onPopupRequest-org.mozilla.geckoview.GeckoSession-java.lang.String-

[philip-lamb]

Moving to 1.3 P1.

[jvonitter]

Flow is ready: https://trello.com/c/EFuMA67f/409-uf-75-pop-up-blocking-override
Waiting on UIS for final design

[jvonitter]

Final design is done: https://trello.com/c/LserbZRw/428-uis-86-pop-up-blocking-override

[jvonitter]

UIS-86 has been updated

[jvonitter]

One minor change here - instead of a button saying "Exceptions", it should say "Settings".

When a user selects Settings, they should see a list of sites they've acted on in the past. They can Allow or Block each site individually from that page, similar to this -

We don't need a search box, but you can re-use the other text on that page ^^.
@thenadj we should update the spec to match but there's no rush.

[jvonitter]

UIS-86 Pop-up Blocking Override

[keianhzo]

@jvonitter Latest APK with switches: https://send.firefox.com/download/b2f578f2d5451e52/#T1QllBrOUiNXOAqBoUjddw

[thenadj]

@keianhzo Just reviewed this and it looks good. One small change I discussed with Janice. Let's rename the 'Settings' button to 'Advanced' just to differentiate it a bit from the Settings dialog the user is already in.

[keianhzo]

@jvonitter @thenadj I've addressed review feedback and comments:

• Pop-up menu button: Settings -> Advanced
• Switch text: Deny -> Block
• Fixed sites were added multiple times
• Inverted site switch to be more consistent with the global pop-up blocking setting: on is blocked, off is allowed

https://send.firefox.com/download/b978cc4e02e546b2/#X8f8Ha64TgAldbvdQpgnNQ

[jvonitter]

UIS-86 Pop-up Blocking Override

[jvonitter]

I did a bit of hallway user testing on this and found it didnt go over well. Reopening so we can make some changes. UIS-86 has been updated.

1. remove the toggle from the exceptions list. if it's in the list, it's an exception. you can remove it from the list (with the X interaction you have here) to change that. I think the list is then called "Exceptions" both on the button and in the title of the dialog.
   And

2. Instead of popping up a popup because we blocked a popup, let's put an icon in the URL bar that signals that we've blocked something. Clicking it would then trigger the popup. that gives users a path to add that site to the exceptions list without having to type the url and without having to be interrupted by the popup