Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add an option to clear history (and cache, cookies, etc.) #336

Closed
cvan opened this issue Aug 10, 2018 · 18 comments
Closed

Add an option to clear history (and cache, cookies, etc.) #336

cvan opened this issue Aug 10, 2018 · 18 comments
Assignees
Labels
enhancement This issue is a new feature or request Final Design Design complete. Any request for design revision must open in a new issue.
Milestone

Comments

@cvan
Copy link
Contributor

cvan commented Aug 10, 2018

It would be nice if there was an option to clear history. It is not a problem currently, as there are not multiple tabs/windows. But a link could be inferred as :visited or an active session (e.g., Google, Facebook, YouTube) could be active when a user closes the browser or leaves it unattended and returns.

@avrignaud
Copy link

Yep, good catch! Will put on list for 1.1 consideration.

@avrignaud avrignaud added enhancement This issue is a new feature or request v1.1 labels Aug 10, 2018
@cvan
Copy link
Contributor Author

cvan commented Sep 7, 2018

For v1.1 this seems quite important - possibly P1?

@avrignaud
Copy link

avrignaud commented Sep 7, 2018

Agree! Just note we're only assigning priorities to 1.0 bugs right now. Everything marked 1.1 will be re-triaged after we launch 1.0 and before we dive in.

@cvan
Copy link
Contributor Author

cvan commented Sep 19, 2018

do we have a design spec for this?

@avrignaud
Copy link

@bluemarvin Can GV clear history if we have the option/button in settings?

@avrignaud avrignaud added P2 Fix in the next development iteration and removed v1.1 labels Oct 30, 2018
@cvan
Copy link
Contributor Author

cvan commented Oct 30, 2018

Not yet but it will. GeckoView's History API is actively being developed but not finished yet. See https://bugzilla.mozilla.org/show_bug.cgi?id=1494713, the platform bug.

Issue #614 tracks the FxR implementation of using the GeckoView android-components API.

@avrignaud
Copy link

Moving to backlog - won't make 1.1

@cvan
Copy link
Contributor Author

cvan commented Nov 1, 2018

Moving to backlog - won't make 1.1

Moving History to 1.1 or a "Clear All" button? Last time I checked, unbookmarking items from History and removing items from History were in the design specs. If we introduce History in 1.1, users need the ability to remove items from their History.

@avrignaud
Copy link

I don't think bookmarking and history is on track for 1.1 - but asked @keianhzo for a quick update.

@cvan
Copy link
Contributor Author

cvan commented Nov 1, 2018

I don't think bookmarking and history is on track for 1.1 - but asked @keianhzo for a quick update.

is there a Doc or a list I can refer to for 1.1?

@avrignaud
Copy link

@cvan Unfortunately, not. The most up to date status is in the GH issues, but we are working on triaging and getting better at making the current project board for 1.1 reflect reality. Going forward, the goal is to have a complete view of current version in the "#.# Project Board" and then a second Product Planning board with features spread out over the next few versions.

@cvan cvan added P3 Backlog and removed P2 Fix in the next development iteration labels Nov 27, 2018
@philip-lamb philip-lamb added this to the v1.2 milestone Mar 11, 2019
@philip-lamb philip-lamb modified the milestones: v1.2, v1.3 May 8, 2019
@philip-lamb philip-lamb added the Needs Design Attention design team label May 8, 2019
@jvonitter
Copy link
Contributor

needed by #1243

@jvonitter jvonitter modified the milestones: v1.3, v1.4 Jul 2, 2019
@jvonitter jvonitter added Draft Design From design team for review PM/UX review PM/UX review needed prior to merge and removed Needs Design Attention design team labels Jul 9, 2019
@ScottWitte
Copy link

I'll add my vote for the need to add cache clearing (separate from history clearing). As a developer, I need to be certain that the changes I make in code and upload are indeed being used when viewing in FxR. If a change doesn't work, is it because I didn't really fix it or the old code is stuck in cache?

BTW, I really hate Safari wiping out everything when I just want a clean cache. Please don't do THAT.

@jvonitter
Copy link
Contributor

@ScottWitte we can look at adding the ability to clear cache separately from history as a developer option. I'll make a new ticket for that, since this is going to just cover history.

@jvonitter
Copy link
Contributor

User flow for seeing history, clearing history and changing history settings: https://trello.com/c/VUiURGJ1/337-uf-62-history

@jvonitter
Copy link
Contributor

jvonitter commented Aug 16, 2019

Spec is complete! https://trello.com/c/CPyXxcZp/371-uis-78-history
Related to #1283

@jvonitter jvonitter added Final Design Design complete. Any request for design revision must open in a new issue. and removed Draft Design From design team for review PM/UX review PM/UX review needed prior to merge labels Aug 16, 2019
@jvonitter jvonitter assigned keianhzo and unassigned jvonitter Aug 16, 2019
@jvonitter
Copy link
Contributor

Spec has been updated with additional options. see https://trello.com/c/NcTaLGB6/412-uf-76-clear-cache-setting

@philip-lamb philip-lamb added P2 Fix in the next development iteration and removed P3 Backlog labels Aug 26, 2019
@keianhzo
Copy link
Contributor

Closing as this has been merged as part of #1517

There is not API in GV at the moment to get the size of the cache so we had to strip that part of the spec.

@philip-lamb philip-lamb removed the P2 Fix in the next development iteration label Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue is a new feature or request Final Design Design complete. Any request for design revision must open in a new issue.
Projects
None yet
Development

No branches or pull requests

6 participants