Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Use Gecko as HTTP client for Glean #3339

Closed
pocmo opened this issue May 6, 2020 · 4 comments · Fixed by #3498
Closed

Use Gecko as HTTP client for Glean #3339

pocmo opened this issue May 6, 2020 · 4 comments · Fixed by #3498
Assignees
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented May 6, 2020

I saw that we are initializing Glean with the default client - which means it will be using HttpUrlConnection.

In AC we have an adapter that wraps GeckoView and will use Gecko instead of HttpUrlConnection. This is what Fenix is using as well. I assume that is something Firefox Reality would want too.

There are two options:

@pocmo
Copy link
Contributor Author

pocmo commented May 6, 2020

If you agree that this is worthwhile then I can try writing a patch for this. :)

@pocmo
Copy link
Contributor Author

pocmo commented May 7, 2020

Just saw that there's already a GeckoViewFetchClient in the repo. So we could just use that!

https://github.com/MozillaReality/FirefoxReality/blob/master/app/src/common/shared/org/mozilla/vrbrowser/browser/engine/GeckoViewFetchClient.kt

@keianhzo
Copy link
Contributor

Thanks @pocmo! Yes, we are already using the GeckoWebExecutor everywhere, I think this was missing because the default Glean configuration used HttpUrlConnection. This should be addressed by #3498 as we migrate to AC 44 there and it forced us to do so.

@pocmo
Copy link
Contributor Author

pocmo commented Jun 15, 2020

Yeah, afaik in the lastest AC version we will require you to explicitly pass in a client.

@pocmo pocmo closed this as completed Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants