You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
I saw that we are initializing Glean with the default client - which means it will be using HttpUrlConnection.
In AC we have an adapter that wraps GeckoView and will use Gecko instead of HttpUrlConnection. This is what Fenix is using as well. I assume that is something Firefox Reality would want too.
There are two options:
Use the Client implementation from AC. However since Firefox Reality and AC are not synchronized on GeckoView versions this could cause breakage if the API in GeckoView changes in a breaking way.
Thanks @pocmo! Yes, we are already using the GeckoWebExecutor everywhere, I think this was missing because the default Glean configuration used HttpUrlConnection. This should be addressed by #3498 as we migrate to AC 44 there and it forced us to do so.
I saw that we are initializing Glean with the default client - which means it will be using
HttpUrlConnection
.In AC we have an adapter that wraps GeckoView and will use Gecko instead of
HttpUrlConnection
. This is what Fenix is using as well. I assume that is something Firefox Reality would want too.There are two options:
Client
implementation from AC. However since Firefox Reality and AC are not synchronized on GeckoView versions this could cause breakage if the API in GeckoView changes in a breaking way.Client
implementation wrapping GeckoView directly to Firefox Reality. Even in AC the code is minimal: https://github.com/mozilla-mobile/android-components/blob/master/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.ktThe text was updated successfully, but these errors were encountered: