Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Settings buttons stop working #2064

Closed
jvonitter opened this issue Oct 24, 2019 · 5 comments · Fixed by #2072
Closed

Settings buttons stop working #2064

jvonitter opened this issue Oct 24, 2019 · 5 comments · Fixed by #2072
Assignees
Milestone

Comments

@jvonitter
Copy link
Contributor

jvonitter commented Oct 24, 2019

Configuration

Firefox Reality version: 6
Firefox Reality build ID: 32971354

Steps to Reproduce

Not totally sure how this happened, but I had been playing with the build for a while. I was able to sign in to my account successfully, so I know the buttons in the settings dialog worked at least once.

Now when I try to go into any of the settings categories, I can see the hexagon buttons responding to hover and press, but the the individual settings menus don't come up. Every so often one of them will work, but it's unpredictable. The privacy button specifically never works.

Video here

@jvonitter jvonitter added this to the #6 features milestone Oct 24, 2019
@jvonitter
Copy link
Contributor Author

jvonitter commented Oct 25, 2019

It turns out if i click the other buttons verrrry carefully while holding the controller in both hands to minimize pointer movement, The buttons work reliably (except for privacy - that never works).
Also if I click down, then move around on the button, the click seems to be released.

@bluemarvin
Copy link
Contributor

We need to make the settings honey comb buttons sticky like the keys on the keyboard.

@bluemarvin
Copy link
Contributor

I have a patch that increases the dead zone by the widgets resolution but even then, as long as the pointer was in the button when pressed, it should get the click no matter how far it moves.

@keianhzo
Copy link
Contributor

I've seen this behavior but it's not particular to the settings but any widget. I need to do a bisect to see when this was introduced.

@keianhzo
Copy link
Contributor

I've posted #2072 that fixes the click on the privacy button issue but we have to investigate the widgets corruption issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants