Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Two or three history feeds are wrongly logged when URL is change via javascript #1839

Closed
Softvision-RemusDranca opened this issue Sep 16, 2019 · 5 comments · Fixed by #2417
Closed
Assignees
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality 1.5-32570012 (6090cf4)

[Affected Platforms]:

  • Oculus Go - Android 7.1.2
  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.

[Steps to reproduce]:

  1. Click the "+" button to open a new window (I opened a new window for a better observation of the issue).
  2. Click the "History" button to open the "History" page.
  3. Focus the other window and navigate to "www.youtube.com".
  4. Click on a suggested video and observe the "History" page.

[Expected results]:

  • A history feed is logged for the opened video.

[Actual results]:

  • Two or three history feeds are logged for the opened video.

[Notes]:

  • The logs have the same URL.
  • Attached is a screen recording of the issue: link
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Sep 16, 2019
@jvonitter jvonitter added this to the v1.5 milestone Sep 17, 2019
@keianhzo
Copy link
Contributor

@bluemarvin Might this be related to the Youtube overriding that we do?

@bluemarvin
Copy link
Contributor

It probably is, I think we need to use the flag that overwrites history when doing the redirect?

@jvonitter jvonitter changed the title Two or three history feeds are wrongly logged when opening videos from Youtube Two or three history feeds are wrongly logged when URL is change via javascript Oct 2, 2019
@bluemarvin
Copy link
Contributor

@jvonitter jvonitter modified the milestones: #5 polish, #6 features Oct 2, 2019
@bluemarvin bluemarvin modified the milestones: #6 features, #7 polish Oct 29, 2019
@bluemarvin
Copy link
Contributor

Still waiting for fix in GV.

@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 8-33472001 (6ba3881) installed on the Oculus Go, Quest, HTC Vive Focus and Focus Plus headsets.
Now, only one history feed is logged when navigating on different videos on youtube or twitch.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
6 participants