Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Allow keyboard to be repositioned #1146

Closed
3 tasks
philip-lamb opened this issue May 2, 2019 · 5 comments · Fixed by #1466
Closed
3 tasks

Allow keyboard to be repositioned #1146

philip-lamb opened this issue May 2, 2019 · 5 comments · Fixed by #1466
Assignees
Labels
enhancement This issue is a new feature or request Final Design Design complete. Any request for design revision must open in a new issue. UX Issue relates to UX
Milestone

Comments

@philip-lamb
Copy link
Contributor

Allow keyboard to be repositioned.

(UX and design aspects are covered in related user testing master issue #480. This issue is to track implementation work.)

  • Implement dynamic positioning (i.e relative to web content) based on design specification.
  • Implement a UI element which allows user to reposition temporarily.
  • Allow the user to pin the keyboard in a preferred location, and to unpin and revert to dynamic positioning.

needed-by #480

@philip-lamb philip-lamb added Needs Design Attention design team UX Issue relates to UX labels May 2, 2019
@philip-lamb philip-lamb added this to the v1.3 milestone May 2, 2019
@philip-lamb philip-lamb added the enhancement This issue is a new feature or request label May 2, 2019
@philip-lamb philip-lamb added the P3 Backlog label May 2, 2019
@jvonitter jvonitter modified the milestones: v1.3, v1.4 Jul 2, 2019
@jvonitter jvonitter added the PM/UX review PM/UX review needed prior to merge label Jul 11, 2019
@jvonitter jvonitter added Final Design Design complete. Any request for design revision must open in a new issue. and removed Needs Design Attention design team labels Jul 23, 2019
@jvonitter
Copy link
Contributor

@thenadj and I have tried the latest of @MortimerGoro 's changes and we love the movable keyboard! the only update we'd like to see is for the keyboard to stay where the user puts it. When the app restarts or the keyboard gets into a weird state (though I'm not sure how that would happen) it can reset itself, but otherwise it should stay where a user left it.

@jvonitter jvonitter added P1 Fix in the current development iteration and removed P3 Backlog labels Jul 23, 2019
@jvonitter jvonitter assigned jvonitter and MortimerGoro and unassigned thenadj and jvonitter Jul 23, 2019
@MortimerGoro
Copy link
Contributor

@jvonitter @thenadj APK with the latest movable keyboard updates: https://send.firefox.com/download/2d50a0430111b165/#3T5GGvRpX8SOlqeNnVTT_Q

Now it saves the latest position

@jvonitter
Copy link
Contributor

Awesome! I'll give it a try today.

@thenadj
Copy link

thenadj commented Jul 26, 2019

Looks and feels great!

@jvonitter
Copy link
Contributor

It's great, overall! I did notice one minor issue - let me know if you want a separate ticket for it:
The pointer gets detached from the move button depending on where the keyboard is when you select/drag. It's particularly noticeable if you put the keyboard all the way to the bottom left, then grab the move button to pull it back into the center. It doesn't do this when the keyboard is at the top of the screen, so my guess is that it's something to do with the angle the keyboard has when it's at the bottom of the screen.

@philip-lamb philip-lamb removed the P1 Fix in the current development iteration label Jul 31, 2019
@jvonitter jvonitter removed the PM/UX review PM/UX review needed prior to merge label Aug 2, 2019
@jvonitter jvonitter added the QA Attention QA label Aug 15, 2019
@Softvision-GeluHaiduc Softvision-GeluHaiduc removed the QA Attention QA label Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue is a new feature or request Final Design Design complete. Any request for design revision must open in a new issue. UX Issue relates to UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants