Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull youtube-regrets JS libraries from CDN, rather than bundling them in #7308

Closed
Pomax opened this issue Sep 2, 2021 · 1 comment
Closed

Comments

@Pomax
Copy link
Contributor

Pomax commented Sep 2, 2021

We currently bundle a bunch of pure frontend libraries into our site's app bundle, even though they're only used on single pages, which means that we're serving a lot of data that most folks will never need, as well as forcing a bundle redownload when these library's versions get bumped, even if nothing else changed. Let's take these out of our bundle, and instead load them from CDN using normal script tags.

These include:

  • chart.js
  • gsap.js
  • count-up.js
  • swiper.js

But I might even still be missing some.

@Pomax
Copy link
Contributor Author

Pomax commented Mar 30, 2022

this has simply not been a concern, closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant