Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: add comments to post detail page #3589

Closed
kristinashu opened this issue Aug 29, 2019 · 9 comments · Fixed by #3842
Closed

Blog: add comments to post detail page #3589

kristinashu opened this issue Aug 29, 2019 · 9 comments · Fixed by #3842
Assignees

Comments

@kristinashu
Copy link

kristinashu commented Aug 29, 2019

From epic ticket #2797

Add comment feature to individual blog post pages similar to PNI and IHR.

By default comments feature should be off but staff should be able to turn them on for specific posts.

Jen C and I can moderate.

@alanmoo should we just Coral Talk for this?

@kristinashu kristinashu added this to the Icebox milestone Aug 29, 2019
@kristinashu kristinashu mentioned this issue Aug 29, 2019
25 tasks
@alanmoo
Copy link
Contributor

alanmoo commented Aug 29, 2019

Yup, absolutely.

@kristinashu kristinashu modified the milestones: Icebox, Sep 9 Sep 3, 2019
@kristinashu kristinashu modified the milestones: Icebox, Nov 11 Oct 25, 2019
@kristinashu
Copy link
Author

This is the P1 from the *Privacy Included work #3801. Deadline is Nov 12.

@alanmoo
Copy link
Contributor

alanmoo commented Oct 25, 2019

@cadecairos Any reason we shouldn't use the same Talk instance as PNI for blogs?

If so, this should be a matter of copying the code from PNI into the blog template. @youriwims we'll need to get you access to whatever instance of talk we're using.

From a functional standpoint, unless I'm missing something in the Talk admin, we'll have to add a flag to the settings of the Blog page model to enable comments, and then conditionally render the div that Coral uses based on a check for that boolean in the template.

@cadecairos
Copy link

Any reason we shouldn't use the same Talk instance as PNI for blogs?

None that I can think of. We should probably look into upgrading that instance.

@alanmoo
Copy link
Contributor

alanmoo commented Oct 25, 2019

And maybe getting it a proper sub domain?

@cadecairos
Copy link

got one in mind?

@alanmoo
Copy link
Contributor

alanmoo commented Oct 25, 2019 via email

@kristinashu
Copy link
Author

No real opinion but maybe comments.mozillafoundation.org would be clearer?

@alanmoo
Copy link
Contributor

alanmoo commented Oct 26, 2019

Great. I'll file a separate devops ticket. @youriwims, please work on this when you're back in Canada; Getting the initial implementation working shouldn't take more than a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants