Subpage titles are missing in title tag

[gvn]

Repro: Go to any subpage and look at the title. It shows Mozilla Foundation - .
Expected: Add the subpage title after the hyphen.

[mmmavis]

Can I assign this ticket to you @gvn 😉 😆

[Pomax]

Turns out this is still an issue - we should probably get that fixed sooner than later =)

[Dhrumilcse]

I am getting started with Open Source and I'd like to work on this issue. Can I?

[Pomax]

Hi @Dhrumilcse, absolutely - have you worked with Wagtail (or Django) and React before?

[Dhrumilcse]

Thanks @Pomax,
I am familiar with Django but I haven't worked with React before. However; I am ready to learn what's necessary. Also, I was looking through the code base and I think <title> section of base.html is where we need modifications. Correct me if I am wrong and guide me further.

[Pomax]

That's correct, except each of the top level pages has their own template in https://github.com/mozilla/foundation.mozilla.org/tree/master/network-api/networkapi/wagtailpages/templates/wagtailpages/static that each needs to specify a new title.

If you look at https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/templates/pages/base.html you can see that https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/templates/pages/base.html#L15 already provisions a block called pageTitle that is supposed to render "Mozilla Foundation - [...]", and where the second part is generated from page.meta_title (page is a provided by wagtail as a context variable) and so the problem is that these pages either do not come with, or do not specify, that meta_title property.

[Dhrumilcse]

Thanks @Pomax
I got it and will work this out. Please assign me this issue.

[Pomax]

I've added the label to "assigned to contributor", as only people who are part of the github org can be "assigned" to issues.

[Dhrumilcse]

Hello team, I need guidance.

Because the foundation website contains a lot of modular code and Django's model-view-template pattern, it was a little difficult for me to reverse engineer it and find the solution. Therefore, I decided to create a small Django project and app on my local machine and run a case same as our issue. I found the solution on the local project. Here is my solution, briefly. In the views.py file of the application, while defining the function for specific pages, we pass the 'template tag' with its definition (in our case, the subpage title) as an argument in the render function. Please find the images containing code of the fix and the desired output.

So, once I got this, I went straight ahead to resolve the issue in the main project but couldn't find the file (views.py, I guess) to fix the issue. Can you tell me how should I fix this or if I am incorrect in any way, will you please guide me to the correct one?

[code]

[output]

[xmatthewx]

Ping @alanmoo @Pomax

[alanmoo]

It looks like this is working on Opportunity and Campaign pages, because the page editor gets to set the "title" property of the page on those templates.

Two relevant lines of code:
https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/templates/pages/base.html#L14

https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/wagtailpages/models.py#L153-L154

It seems like the main thing we need is for unique page templates to set a title in their model, and the base template should pick it up.