Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7] Initiate JWT Integration and Core Refactoring #82

Merged
merged 7 commits into from
Dec 10, 2023
Merged

[#7] Initiate JWT Integration and Core Refactoring #82

merged 7 commits into from
Dec 10, 2023

Conversation

skgndi12
Copy link
Collaborator

@skgndi12 skgndi12 commented Dec 8, 2023 •
edited
Loading

#7

Changes

  • Introduce JWT packages
  • Reorganize ports into core
  • Configure JWT settings
  • Define JWT interface
  • Define application ID token
  • Describe application payload
  • Add script for RSA key generation
  • Implement utility functions
    • Fetch current time in seconds
    • Perform time addition
    • Check for string enum value

@skgndi12 skgndi12 added enhancement New feature or request api labels Dec 8, 2023
@skgndi12 skgndi12 self-assigned this Dec 8, 2023
@skgndi12 skgndi12 force-pushed the feature/issue-7/implement-jwt-adapter branch from 1723d6d to 9ea2290 Compare December 8, 2023 09:33
isutare412
isutare412 reviewed Dec 8, 2023
View reviewed changes
api/config/default.yaml Show resolved Hide resolved
api/src/util/time.ts Outdated Show resolved Hide resolved
api/src/util/time.ts Outdated Show resolved Hide resolved
api/src/util/time.ts Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review December 8, 2023 11:54
@skgndi12 skgndi12 force-pushed the feature/issue-7/implement-jwt-adapter branch 2 times, most recently from 2447ff5 to 2b8b549 Compare December 10, 2023 05:10
@isutare412 isutare412 self-requested a review December 10, 2023 05:19
2wheeh
2wheeh reviewed Dec 10, 2023
View reviewed changes
api/src/util/time.ts Outdated Show resolved Hide resolved
isutare412
isutare412 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 👍

@skgndi12 skgndi12 force-pushed the feature/issue-7/implement-jwt-adapter branch from c1a4cd4 to fdf4067 Compare December 10, 2023 07:41
@skgndi12 skgndi12 merged commit 9c945ad into MovieReviewComment:develop Dec 10, 2023
1 check passed
@skgndi12 skgndi12 deleted the feature/issue-7/implement-jwt-adapter branch December 10, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2wheeh 2wheeh 2wheeh left review comments

@isutare412 isutare412 isutare412 approved these changes

Assignees

@skgndi12 skgndi12

Labels
api enhancement New feature or request
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skgndi12 @isutare412 @2wheeh